Skip to content

docs: add GPT-5.6 Sol and Terra to the predefined agent LLM models - #11440

Open
igorlukanin wants to merge 1 commit into
masterfrom
igor/cub-3581-document-gpt-5-6-models
Open

docs: add GPT-5.6 Sol and Terra to the predefined agent LLM models#11440
igorlukanin wants to merge 1 commit into
masterfrom
igor/cub-3581-document-gpt-5-6-models

Conversation

@igorlukanin

Copy link
Copy Markdown
Member

Adds GPT-5.6 Sol and Terra to the list of predefined models for an agent's llm property.

@igorlukanin
igorlukanin requested a review from keydunov as a code owner July 31, 2026 20:55
@mintlify

mintlify Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟢 Ready View Preview Jul 31, 2026, 8:57 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@claude

claude Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 30s —— View job


Review: docs-only addition — no issues found ✅

Details (0 high, 0 medium, 0 low)
  • Gather context (PR diff, changed file, repo docs conventions)
  • Understand the request (docs review)
  • Review the change
  • Post review

What changed: two entries appended to the OpenAI GPT list of predefined llm values in docs-mintlify/admin/ai/index.mdx:93-94.

- `gpt_5_4`
+ `gpt_5_6_sol`
+ `gpt_5_6_terra`
- `o3`

Assessment:

  • Correct file — this is the active /docs-mintlify site, not the deprecated /docs. ✅
  • Placement and ordering are consistent with the surrounding list: version-ascending within the GPT group, o* reasoning models still last. ✅
  • Naming style matches the existing convention (lowercase, _-separated version, variant suffix), same shape as gpt_5_mini. ✅
  • Surgical edit to an existing page rather than new content — matches docs-mintlify/CLAUDE.md guidance. ✅
  • No new page, so no docs.json navigation update is needed. ✅
  • Nothing security-, performance-, or test-related applies to a two-line list addition. No test coverage gap: these identifiers aren't defined anywhere in this repo (grep for gpt_5_4/gpt_5_3 matches only this doc page), so the enum is validated on the Cube cloud side.

One thing I can't verify from this repo: because the model identifiers live outside the monorepo, I can't confirm that gpt_5_6_sol and gpt_5_6_terra are the exact strings the platform accepts. Worth a quick check against the cloud-side enum before merge — a typo here would only surface as a runtime config error for users.

Optional, not blocking: the list doesn't indicate which models are available on which plan tiers or which are recommended defaults, so readers picking a model get no guidance. That's pre-existing and out of scope for this PR.

• branch [`igor/cub-3581-document-gpt-5-6-models`](https://github.com/cube-js/cube/tree/igor/cub-3581-document-gpt-5-6-models)

@igorlukanin

Copy link
Copy Markdown
Member Author

Checked the cloud-side enum: both keys match exactly. gpt_5_6_sol and gpt_5_6_terra are the strings added to PredefinedLLMProviders in cubedevinc/cube-runtime#1112 and to the predefined_llm enum in cubedevinc/cubejs-enterprise#13569, so no typo to catch. This PR lands last of the three for that reason.

@igorlukanin
igorlukanin force-pushed the igor/cub-3581-document-gpt-5-6-models branch from 98bbcb6 to 3e79c10 Compare August 8, 2026 14:24
@claude

claude Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 28s —— View job


Review: docs-only addition — no issues found ✅

Details (0 high, 0 medium, 0 low)
  • Gather context (PR diff, changed file, docs conventions)
  • Understand the request (docs review, re-run on synchronize)
  • Check for stale review threads to resolve
  • Review the change
  • Post review

What changed — unchanged from my previous pass; the diff against origin/master is still exactly two appended list entries in docs-mintlify/admin/ai/index.mdx:93-94:

  - `gpt_5_4`
+ - `gpt_5_6_sol`
+ - `gpt_5_6_terra`
  - `o3`

Assessment:

  • Correct file — the active /docs-mintlify site, not the deprecated /docs. ✅
  • Placement and ordering match the surrounding list: version-ascending within the GPT group, o* models still last. ✅
  • Naming matches the existing convention (lowercase, _-separated version, variant suffix), same shape as gpt_5_mini. ✅
  • Surgical edit to an existing page — matches docs-mintlify/CLAUDE.md guidance on preferring small edits over new content. ✅
  • No new page, so no docs.json navigation update needed. ✅
  • Nothing security-, performance-, or test-related applies to a two-line list addition. No test-coverage gap: these identifiers aren't defined anywhere in this repo, so the enum is validated cloud-side.

Previously open question — now closed. I'd flagged that I couldn't verify the exact strings from this repo. @igorlukanin confirmed both keys match the cloud-side enum (PredefinedLLMProviders in cube-runtime#1112, predefined_llm in cubejs-enterprise#13569), and that this PR intentionally lands last of the three. Nothing left to check.

No unresolved review threads on this PR, so nothing to resolve or dedupe against.

Optional, not blocking and pre-existing: the list gives no signal about plan-tier availability or which model is the recommended default, so readers picking a model get no guidance. Out of scope here.

• branch igor/cub-3581-document-gpt-5-6-models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant